From fc0a97466617a93d73172df2b00c07f890a953c3 Mon Sep 17 00:00:00 2001
From: Abdul Malik Ikhsan <samsonasik@gmail.com>
Date: Mon, 23 Dec 2024 07:54:39 +0700
Subject: [PATCH] add read const fetch support

---
 ...eger_attribute_read_constant_fetch.php.inc | 55 +++++++++++++++++++
 ...ingWithIntegerIdAttributeConstantFetch.php | 19 +++++++
 .../Source/ValueObject/DoctrineType.php       | 11 ++++
 src/TypeAnalyzer/CollectionTypeFactory.php    |  8 ++-
 4 files changed, 90 insertions(+), 3 deletions(-)
 create mode 100644 rules-tests/CodeQuality/Rector/Property/ImproveDoctrineCollectionDocTypeInEntityRector/Fixture/OneToMany/with_index_by_integer_attribute_read_constant_fetch.php.inc
 create mode 100644 rules-tests/CodeQuality/Rector/Property/ImproveDoctrineCollectionDocTypeInEntityRector/Source/TrainingWithIntegerIdAttributeConstantFetch.php
 create mode 100644 rules-tests/CodeQuality/Rector/Property/ImproveDoctrineCollectionDocTypeInEntityRector/Source/ValueObject/DoctrineType.php

diff --git a/rules-tests/CodeQuality/Rector/Property/ImproveDoctrineCollectionDocTypeInEntityRector/Fixture/OneToMany/with_index_by_integer_attribute_read_constant_fetch.php.inc b/rules-tests/CodeQuality/Rector/Property/ImproveDoctrineCollectionDocTypeInEntityRector/Fixture/OneToMany/with_index_by_integer_attribute_read_constant_fetch.php.inc
new file mode 100644
index 00000000..56b2cbd8
--- /dev/null
+++ b/rules-tests/CodeQuality/Rector/Property/ImproveDoctrineCollectionDocTypeInEntityRector/Fixture/OneToMany/with_index_by_integer_attribute_read_constant_fetch.php.inc
@@ -0,0 +1,55 @@
+<?php
+
+namespace Rector\Doctrine\Tests\CodeQuality\Rector\Property\ImproveDoctrineCollectionDocTypeInEntityRector\Fixture\OneToMany;
+
+use Doctrine\Common\Collections\Collection;
+use Doctrine\ORM\Mapping as ORM;
+use Rector\Doctrine\Tests\CodeQuality\Rector\Property\ImproveDoctrineCollectionDocTypeInEntityRector\Source\TrainingWithIntegerIdAttributeConstantFetch;
+
+/**
+ * @ORM\Entity
+ */
+class WithIndexByIntegerAttributeReadConstantFetch
+{
+    /**
+     * @var Collection<int, string>|TrainingWithIntegerIdAttributeConstantFetch[]
+     */
+    #[ORM\OneToMany(targetEntity: TrainingWithIntegerIdAttributeConstantFetch::class, mappedBy: 'trainer', indexBy: 'id')]
+    private $trainings = [];
+
+    /**
+     * @var Collection<int, string>|TrainingWithIntegerIdAttributeConstantFetch[]
+     */
+    #[ORM\OneToMany(targetEntity: TrainingWithIntegerIdAttributeConstantFetch::class, mappedBy: 'trainer', indexBy: 'id2')]
+    private $trainings2 = [];
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Doctrine\Tests\CodeQuality\Rector\Property\ImproveDoctrineCollectionDocTypeInEntityRector\Fixture\OneToMany;
+
+use Doctrine\Common\Collections\Collection;
+use Doctrine\ORM\Mapping as ORM;
+use Rector\Doctrine\Tests\CodeQuality\Rector\Property\ImproveDoctrineCollectionDocTypeInEntityRector\Source\TrainingWithIntegerIdAttributeConstantFetch;
+
+/**
+ * @ORM\Entity
+ */
+class WithIndexByIntegerAttributeReadConstantFetch
+{
+    /**
+     * @var \Doctrine\Common\Collections\Collection<string, \Rector\Doctrine\Tests\CodeQuality\Rector\Property\ImproveDoctrineCollectionDocTypeInEntityRector\Source\TrainingWithIntegerIdAttributeConstantFetch>
+     */
+    #[ORM\OneToMany(targetEntity: TrainingWithIntegerIdAttributeConstantFetch::class, mappedBy: 'trainer', indexBy: 'id')]
+    private $trainings = [];
+
+    /**
+     * @var \Doctrine\Common\Collections\Collection<int, \Rector\Doctrine\Tests\CodeQuality\Rector\Property\ImproveDoctrineCollectionDocTypeInEntityRector\Source\TrainingWithIntegerIdAttributeConstantFetch>
+     */
+    #[ORM\OneToMany(targetEntity: TrainingWithIntegerIdAttributeConstantFetch::class, mappedBy: 'trainer', indexBy: 'id2')]
+    private $trainings2 = [];
+}
+
+?>
diff --git a/rules-tests/CodeQuality/Rector/Property/ImproveDoctrineCollectionDocTypeInEntityRector/Source/TrainingWithIntegerIdAttributeConstantFetch.php b/rules-tests/CodeQuality/Rector/Property/ImproveDoctrineCollectionDocTypeInEntityRector/Source/TrainingWithIntegerIdAttributeConstantFetch.php
new file mode 100644
index 00000000..e7bb39e9
--- /dev/null
+++ b/rules-tests/CodeQuality/Rector/Property/ImproveDoctrineCollectionDocTypeInEntityRector/Source/TrainingWithIntegerIdAttributeConstantFetch.php
@@ -0,0 +1,19 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Doctrine\Tests\CodeQuality\Rector\Property\ImproveDoctrineCollectionDocTypeInEntityRector\Source;
+
+use Doctrine\ORM\Mapping as ORM;
+use Rector\Doctrine\Tests\CodeQuality\Rector\Property\ImproveDoctrineCollectionDocTypeInEntityRector\Source\ValueObject\DoctrineType;
+
+final class TrainingWithIntegerIdAttributeConstantFetch
+{
+    #[ORM\Column(name: 'id', type: DoctrineType::STRING)]
+    #[ORM\Id]
+    private string $id;
+
+    #[ORM\Column(name: 'id2', type: DoctrineType::INTEGER)]
+    #[ORM\Id]
+    private int $id2;
+}
diff --git a/rules-tests/CodeQuality/Rector/Property/ImproveDoctrineCollectionDocTypeInEntityRector/Source/ValueObject/DoctrineType.php b/rules-tests/CodeQuality/Rector/Property/ImproveDoctrineCollectionDocTypeInEntityRector/Source/ValueObject/DoctrineType.php
new file mode 100644
index 00000000..678685da
--- /dev/null
+++ b/rules-tests/CodeQuality/Rector/Property/ImproveDoctrineCollectionDocTypeInEntityRector/Source/ValueObject/DoctrineType.php
@@ -0,0 +1,11 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Doctrine\Tests\CodeQuality\Rector\Property\ImproveDoctrineCollectionDocTypeInEntityRector\Source\ValueObject;
+
+class DoctrineType
+{
+    public const INTEGER = 'integer';
+    public const STRING = 'string';
+}
\ No newline at end of file
diff --git a/src/TypeAnalyzer/CollectionTypeFactory.php b/src/TypeAnalyzer/CollectionTypeFactory.php
index f9c87387..32da7765 100644
--- a/src/TypeAnalyzer/CollectionTypeFactory.php
+++ b/src/TypeAnalyzer/CollectionTypeFactory.php
@@ -20,12 +20,14 @@
 use Rector\BetterPhpDocParser\PhpDocInfo\PhpDocInfo;
 use Rector\BetterPhpDocParser\PhpDocInfo\PhpDocInfoFactory;
 use Rector\PhpParser\AstResolver;
+use Rector\PhpParser\Node\Value\ValueResolver;
 
 final readonly class CollectionTypeFactory
 {
     public function __construct(
         private PhpDocInfoFactory $phpDocInfoFactory,
-        private AstResolver $astResolver
+        private AstResolver $astResolver,
+        private ValueResolver $valueResolver
     ) {
     }
 
@@ -153,8 +155,8 @@ private function resolveKeyFromAttribute(Class_ $class, string $key): IntegerTyp
             foreach ($attrGroup->attrs as $attr) {
                 if ($attr->name->toString() === 'Doctrine\ORM\Mapping\Column') {
                     foreach ($attr->args as $arg) {
-                        if ($arg->name instanceof Identifier && $arg->name->name === 'type' && $arg->value instanceof String_) {
-                            $type = $arg->value->value;
+                        if ($arg->name instanceof Identifier && $arg->name->name === 'type') {
+                            $type = $this->valueResolver->getValue($arg->value);
                             return $type === 'string' ? new StringType() : new IntegerType();
                         }
                     }