-
-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTP client: Support compression (Content-Encoding: gzip) #377
Comments
For buffered responses, it's as easy as doing gzdecode/gzdeflate(), or does it need async solutions? |
IIRC you can decode streams in chunks, and either me or @clue might have the package for it lying around AFAIK |
How will this library change with reactphp v3? Will changes to this library still be accepted? |
@maxgalbu You can read about our rough plans for each project and ReactPHP in whole in our discussion: https://github.com/orgs/reactphp/discussions/481
While ReactPHP v3 will be the way forward, we are also committed to continue supporting the current v1 for a certain amount of time, if you have any ideas or want to contribute to the project, we're happy to take a look. In short: Yes, changes will be accepted 👍 |
This library should support requesting compressed responses and automatically decompress using the
Accept-Encoding
request header andContent-Encoding
response header.This should be an opt-in feature.
Implementing this for buffered requests shouldn't be too hard. This should make sure to also respect the
withResponseBuffer()
setting.Implementing this for streaming requests is doable, see also https://github.com/clue/reactphp-zlib.
We welcome contributions, reach out if you want to support this project 👍
The text was updated successfully, but these errors were encountered: