-
-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue with docs/handbook/dependency-inversion/index.md #292
Comments
Splat is everywhere throughout reactiveui code base. So we make calls to splat to determine which views or adapters are used. You have no choice in some capacity to use Splat but we are starting to add DI adapters to allow it to talk to other engines |
I guess this talk does not give a clear reference to an article, so here it is: https://reactiveui.net/docs/handbook/dependency-inversion/
|
Thanks for the feedback something we can make more explicit for sure |
@glennawatson What I ment was that it is completely unclear how to integrate Splat into a new Xamarin.Forms project. The article shows how to register services and how to manually resolve them. But will ReactiveUI resolve them automatically after that? Or should we take another step? Maybe we do not need that another step and can use Splat side by side with Xamarin.Forms.DependencyService? |
You can definitely work side by side with it. We are adding a bunch of DI engine adapters to Splat at the moment so might add to the list the Xamarin.Forms.DependencyService as an adapter. What this does is makes Splat's backing store for the values whatever DI engine is used in the adapter. |
Do you plan to add IServiceCollection (for registration) and IServiceProvider (to resolve) from Microsoft.Extensions.DependencyInjection? |
I am wondering what the desire is to have a web DI Adapter for a UI framework that targets desktop and mobile? Not saying that we shouldn't or won't do it, I am just trying to understand the sell. Is WPF going to be wiring into the same abstractions? The framework currently sits under asp.net which is not a framework we support at the moment. |
Some people use it in web frameworks (eg Geoffrey Huntley has used it in this case). |
Sorry for late reply - I've been busy with another project. I wouldn't drop Microsoft.Extensions.DependencyInjection.Abstractions just because it sits under asp.net, not under something else. On the other hand: if it does not suit ReactiveUI because of technical reasons - than of course it should not be supported. |
It is absolutely unclear how to register/start using Splat within Xamarin.Forms. Simply registering interfaces+implementations within Splat's Locator.CurrentMutable does not make Splat a default DI container.
The text was updated successfully, but these errors were encountered: