Replies: 2 comments
-
I'd be inclined to keep the current logging functionality as is. It has more flexibility for existing users who rely on the full name. |
Beta Was this translation helpful? Give feedback.
-
What would be a scenario where someone would rely on specific generated httpClient name? |
Beta Was this translation helpful? Give feedback.
-
Currently the generated name for Refit
HttpClient
also contains assembly full name as visible here:refit/Refit/UniqueName.cs
Line 49 in 246ee8d
This results in name like
System.Net.Http.HttpClient.Refit.Implementation.Generated+SerilogRefiReproControllersIApi, SerilogRefiRepro, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null
which makes name long a bloated in scenarios like logging - see the issue here.Even without the assembly full name, the generated name would be unique in cases when the refit interface with the same name would be also defined in another assembly, as the namespace that is already included right after
+
would be different.Would it be possible to get rid of the assembly name?
Beta Was this translation helpful? Give feedback.
All reactions