-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a file name and a line number to the logs #18
Comments
Gili:
I appreciate the suggestion. I'd thought about adding filename and line
numbers to the log, but chose not to make it always do that. For example,
someone might want to use ulog for real-time event tracking where filename
and line number are not relevant (though the timestamp is). And if you
_do_ want filenames and line numbers, you can add them to the call, such as:
ULOG_INFO("%s(%s):Info, arg=%d", __FILE__, __LINE__, arg);
Best regards,
- Robert
…On Sun, Oct 29, 2023 at 9:08 AM kammagili ***@***.***> wrote:
I have a suggestion to add a file name and a line number to the log.
https://github.com/kammagili/ulog.git
Please Contact me, if relevant
***@***.***
Thank you
Gili
—
Reply to this email directly, view it on GitHub
<#18>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANWQQJVW7B37TPCJUVSPHDYBZWPJAVCNFSM6AAAAAA6U57V4KVHI2DSMVQWIX3LMV43ASLTON2WKOZRHE3DOMBVGA3DSNA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Hi Robert,
Thank you for your mail.
Unfortunately, I didn't commit my changes to the github public (I feel
pretty stupid..).
Here are the changes:
kammagili@7eea12c
kammagili@44a2085
In the implementation itself (my_console_logger etc) the user can decide
whether to use it.
Of course, it is your decision to add it or not (and this is not
right/wrong).
Anyway, I wanted to say thanks for the code, It was very easy to use and
integrate.
If you would decide to integrate my suggestion, let me know how it should
be done.
I am also attaching the files just to be sure I am not missing anything
again.
All the best,
Gili
On Sun, 5 Nov 2023 at 01:59, R. Dunbar Poor ***@***.***>
wrote:
… Gili:
I appreciate the suggestion. I'd thought about adding filename and line
numbers to the log, but chose not to make it always do that. For example,
someone might want to use ulog for real-time event tracking where filename
and line number are not relevant (though the timestamp is). And if you
_do_ want filenames and line numbers, you can add them to the call, such
as:
ULOG_INFO("%s(%s):Info, arg=%d", __FILE__, __LINE__, arg);
Best regards,
- Robert
On Sun, Oct 29, 2023 at 9:08 AM kammagili ***@***.***> wrote:
> I have a suggestion to add a file name and a line number to the log.
> https://github.com/kammagili/ulog.git
> Please Contact me, if relevant
> ***@***.***
>
> Thank you
> Gili
>
> —
> Reply to this email directly, view it on GitHub
> <#18>, or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/AANWQQJVW7B37TPCJUVSPHDYBZWPJAVCNFSM6AAAAAA6U57V4KVHI2DSMVQWIX3LMV43ASLTON2WKOZRHE3DOMBVGA3DSNA>
> .
> You are receiving this because you are subscribed to this thread.Message
> ID: ***@***.***>
>
—
Reply to this email directly, view it on GitHub
<#18 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BDTDS56AY4EEO5DL7XD6WLDYC3JHPAVCNFSM6AAAAAA6U57V4KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJTGU4DINRSHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
I think this issue can be closed now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I have a suggestion to add a file name and a line number to the log.
https://github.com/kammagili/ulog.git
Please Contact me, if relevant
[email protected]
Thank you
Gili
The text was updated successfully, but these errors were encountered: