Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure backpressure is maintained in streams #44

Open
rubensworks opened this issue Nov 12, 2020 · 0 comments
Open

Ensure backpressure is maintained in streams #44

rubensworks opened this issue Nov 12, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@rubensworks
Copy link
Member

There may be some places where we are not adhering to Node's backpressure conventions with regards to streams.

Concretely, we seem to be creating new streams (such as Readable, PassThrough and Transform), and push-ing into them (via a 'data' handler on another stream). Node handles backpressuring via the return value of push, which we are ignoring in this manner.

A better solution would be to simply pipe instead of calling push on each data element.

Related to rubensworks/rdf-parse.js@269c757

@rubensworks rubensworks added the enhancement New feature or request label Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant