Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

es6 modules vs rnode-grpc-js #38

Closed
dckc opened this issue Jun 24, 2020 · 4 comments
Closed

es6 modules vs rnode-grpc-js #38

dckc opened this issue Jun 24, 2020 · 4 comments
Labels
rchat more relevant to rchat; transfer?

Comments

@dckc
Copy link
Contributor

dckc commented Jun 24, 2020

I'm trying to use es6 modules and no build step - just ship them straight to the browser.

I thought I had a conflict with grpc-web, which hasn't made the jump from commonjs grpc/grpc-web#535

But @tgrospic clarified that I don't need to use gRPC. Just protobuf for signing deploys.

Meanwhile, elliptic and blakejs are commonjs.

snowpack will almost make up the difference, but commonjs modules only export a default, and @tgrospic/rnode-grpc-js does import { ec } from 'elliptic'. Snowpack has a namedExports work-around, but it's only working in snowpack dev mode, not snowpack build mode.

I think I can avoid importing @tgrospic/rnode-grpc-js...

See also: tgrospic/rnode-grpc-js#8

cc @TheoXD

@dckc
Copy link
Contributor Author

dckc commented Jun 25, 2020

I worked around this issue in 2f30491 .

I should at least raise an issue in rnode-grpc-js before closing this one.

@TheoXD reminded me that rchain-toolkit is another option. I wonder if it's intended for browser depolyment.

cc @fabcotech

@tgrospic
Copy link
Member

@dckc I've posted the function you need to serialize deploy data. You don't need rnode-grpc-js on the web.
tgrospic/rnode-grpc-js#8 (comment)

@dckc
Copy link
Contributor Author

dckc commented Aug 7, 2020

progress:

  1. fc2ce66 sign deploy without grpc-tools
  2. ab6921b never mind rchain-proto

@dckc dckc modified the milestone: gov1 Sep 10, 2020
@dckc
Copy link
Contributor Author

dckc commented Sep 15, 2020

fixed in #53

@dckc dckc closed this as completed Sep 15, 2020
@dckc dckc added the rchat more relevant to rchat; transfer? label Sep 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rchat more relevant to rchat; transfer?
Projects
None yet
Development

No branches or pull requests

2 participants