Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved detail in game log messages in chat #32

Open
danwang opened this issue Apr 8, 2020 · 1 comment
Open

improved detail in game log messages in chat #32

danwang opened this issue Apr 8, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@danwang
Copy link
Contributor

danwang commented Apr 8, 2020

Screen Shot 2020-04-07 at 10 21 15 PM

suggestion: if the backend can return structured data message like

{
  type: 'play',
  player: PlayerID,
  cards: Array[Card],
}

we could render in the chat more detailed information, like

  • rendering cards as displayed number + suit instead of the card text
  • making names clickable, or rendering them in a different color depending on team
@rbtying
Copy link
Owner

rbtying commented Apr 8, 2020

this seems very reasonable / not very hard to do!

We'd want to update the messages returned from functions on GameState to be a new GameMessage enum which derives Serialize and Deserialize, and render the relevant strings in the frontend.

@rbtying rbtying added the enhancement New feature or request label Apr 8, 2020
@rbtying rbtying linked a pull request Apr 13, 2020 that will close this issue
@rbtying rbtying removed a link to a pull request Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants