Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QUANTILE_AVAILABLE is set incorrectly. #302

Open
terraflops1048576 opened this issue Dec 12, 2023 · 0 comments
Open

QUANTILE_AVAILABLE is set incorrectly. #302

terraflops1048576 opened this issue Dec 12, 2023 · 0 comments

Comments

@terraflops1048576
Copy link

Hi, I was looking through the source code, and I noticed this in https://github.com/ray-project/xgboost_ray/blob/master/xgboost_ray/matrix.py

try:
    from xgboost.core import QuantileDmatrix

    QUANTILE_AVAILABLE = True
except ImportError:
    QuantileDmatrix = object
    QUANTILE_AVAILABLE = False

QUANTILE_AVAILABLE is used in https://github.com/ray-project/xgboost_ray/blob/master/xgboost_ray/main.py to enable the use of QuantileDMatrix instead of DMatrix, but this is always set to be False:

import xgboost_ray.matrix
print(xgboost_ray.matrix.QUANTILE_AVAILABLE) # always prints "False"

I believe the error is one of capitalization; QuantileDmatrix should be changed to QuantileDMatrix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant