Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unintuitive naming of RayDMatrix class #37

Open
mirekphd opened this issue Sep 2, 2022 · 1 comment
Open

Unintuitive naming of RayDMatrix class #37

mirekphd opened this issue Sep 2, 2022 · 1 comment

Comments

@mirekphd
Copy link

mirekphd commented Sep 2, 2022

I've just realized that RayDMatrix class in lightgbm_ray is named xgboost_ray.matrix.RayDMatrix, rather than lightgbm_ray.matrix.RayDMatrix.

I understand code re-use, but name re-use? It is apparently by design (as per docs), but in my opinion it violates the principle of least astonishment and thus should be changed to a more intuitive lightgbm_ray.matrix.RayDMatrix.

To reproduce:

from lightgbm_ray import RayParams as test1, RayDMatrix as test2
print([test1, test2])

Output:

[<class 'lightgbm_ray.main.RayParams'>, <class 'xgboost_ray.matrix.RayDMatrix'>]

@mirekphd mirekphd changed the title incorrect naming of RayDMatrix class Unintuitive naming of RayDMatrix class Sep 2, 2022
@matthewdeng
Copy link

@Yard1 would aliasing the class work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants