You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've just realized that RayDMatrix class in lightgbm_ray is named xgboost_ray.matrix.RayDMatrix, rather than lightgbm_ray.matrix.RayDMatrix.
I understand code re-use, but name re-use? It is apparently by design (as per docs), but in my opinion it violates the principle of least astonishment and thus should be changed to a more intuitive lightgbm_ray.matrix.RayDMatrix.
To reproduce:
from lightgbm_ray import RayParams as test1, RayDMatrix as test2
print([test1, test2])
I've just realized that
RayDMatrix
class inlightgbm_ray
is namedxgboost_ray.matrix.RayDMatrix
, rather thanlightgbm_ray.matrix.RayDMatrix
.I understand code re-use, but name re-use? It is apparently by design (as per docs), but in my opinion it violates the principle of least astonishment and thus should be changed to a more intuitive
lightgbm_ray.matrix.RayDMatrix
.To reproduce:
Output:
[<class 'lightgbm_ray.main.RayParams'>, <class 'xgboost_ray.matrix.RayDMatrix'>]
The text was updated successfully, but these errors were encountered: