[Feature]: Add a new event type FailedToDeleteWorkerPodCollection #2680
+10
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheyuWu
changed the title
MortalHappiness
requested changes
Dec 22, 2024
There was a problem hiding this comment.
Check all places that use FailedToDeleteWorkerPod, and change them to FailedToDeleteWorkerPodCollection if DeleteAllOf is used instead of Delete.
Ref: https://github.com/ray-project/kuberay/pull/2663/files#r1893148428
|
@MortalHappiness I searched for functions related to |
kevin85421
requested changes
Dec 23, 2024
CheyuWu
force-pushed
the
feat/eventType/FailedToDeleteWorkerPodCollection
branch
from
e101a6b to
debd1e1
Compare
|
@MortalHappiness @kevin85421 I have checked all of the functions related to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Currently, we are reusing the
FailedToDeleteWorkerPodevent type for scenarios where bothDelete(requiring thedeleteverb inRoleorClusterRole) andDeleteAllOf(requiring thedeletecollectionverb) are involved. However, this reuse may lead to confusion because these operations rely on different verbs and permissions.To improve clarity and maintainability, we should consider introducing a new event type specific to the
DeleteAllOfoperation.Related issue number
Closes #2672
Checks