Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] apiserver API + Client do not support setting headServiceAnnotations #2626

Open
2 tasks done
metasyn opened this issue Dec 9, 2024 · 2 comments
Open
2 tasks done
Labels
apiserver bug Something isn't working

Comments

@metasyn
Copy link
Contributor

metasyn commented Dec 9, 2024

Search before asking

  • I searched the issues and found no similar issues.

KubeRay Component

apiserver

What happened + What you expected to happen

If you see the RayClusterSpec CRD:

It defines a field headServiceAnnotations

However in the KubeRay API Server:

It is not present, so you cannot set this via the API Server's version of the KubeRay CRD API.

There is also no way to set the headServiceAnnotations in the python-apiserver-client:

Reproduction script

There isn't a repro relevant here other than confirm the links above.

Anything else

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@metasyn metasyn added bug Something isn't working triage labels Dec 9, 2024
@metasyn
Copy link
Contributor Author

metasyn commented Dec 11, 2024

I think #708 was closed without having done this for the api server component

@kevin85421
Copy link
Member

cc @YQ-Wang @han-steve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apiserver bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants