Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dish diameter -> weight error #22

Open
TariqBlecher opened this issue Oct 30, 2015 · 3 comments
Open

dish diameter -> weight error #22

TariqBlecher opened this issue Oct 30, 2015 · 3 comments

Comments

@TariqBlecher
Copy link

If one is unfortunate enough to have the DISH_DIAMETER set to zero in the antenna table, this will cause the WEIGHT column to be nan which will prevent imaging. Perhaps an error message somewhere will suffice...

@o-smirnov
Copy link
Collaborator

Arguably weight should be 0 in this case (a 0m dish will have infinite noise thus 0 weight), but if NaN is what CASA sets it to, then it is what it is...

We can't really put a sanity check on every input. When people try to do that, they invariably err on the side of over-restrictiveness, and only cause more complaints. A warning is ok, but I wouldn't call this a high priority fix...

@SpheMakh
Copy link
Collaborator

SpheMakh commented Nov 2, 2015

I can appreciate why CASA puts NaNs if dish size is zero. The WEIGHT column should only be populated if you set elevation and/or shadow limits, therefore having a non-physical dish size should lead to a NaN. If one specifies elevation and shadow limits they should make sure that the dish parameters are reasonable.

@SpheMakh
Copy link
Collaborator

SpheMakh commented Nov 2, 2015

Anyway you need to know the dish size to set these limits in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants