Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Implement wrapper around spdlog in rmm #1709

Open
vyasr opened this issue Oct 21, 2024 · 0 comments · May be fixed by #1722
Open

[FEA] Implement wrapper around spdlog in rmm #1709

vyasr opened this issue Oct 21, 2024 · 0 comments · May be fixed by #1722
Labels
? - Needs Triage Need team to review and classify feature request New feature or request

Comments

@vyasr
Copy link
Contributor

vyasr commented Oct 21, 2024

Is your feature request related to a problem? Please describe.
Currently rmm's logger uses spdlog directly. This approach is problematic because it makes spdlog a dependency of every consumer of rmm. spdlog the library is not inherently problematic, but its centrality makes it a troublesome dependency to deal with in a packaging sense because of the web of constraints it imposes on a dependency tree.

Describe the solution you'd like
As part of rapidsai/build-planning#104, we should first explore how to make spdlog a non-transitive dependency of rmm. In order to accomplish this, we will have to isolate the dependence to something like an inline header that is intended to be compiled into a unique TU by the consumer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
? - Needs Triage Need team to review and classify feature request New feature or request
Projects
Status: Todo
Development

Successfully merging a pull request may close this issue.

1 participant