Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] can I rely on Series. _from_column ? #17483

Open
martindurant opened this issue Dec 2, 2024 · 3 comments
Open

[DOC] can I rely on Series. _from_column ? #17483

martindurant opened this issue Dec 2, 2024 · 3 comments
Labels
doc Documentation question Further information is requested

Comments

@martindurant
Copy link

Report needed documentation

#16454 stopped the ability to create Series from column objects, and introduces the _from_column class method to achieve the same. awkward and akimbo-cudf were using this code path. Can we call the new class method and expect it to be supported?

@jakirkham suggested posting this issue.

awkward PR: scikit-hep/awkward#3309

akimbo PR: intake/akimbo#88

@martindurant martindurant added the doc Documentation label Dec 2, 2024
@Matt711 Matt711 added the question Further information is requested label Dec 2, 2024
@bdice
Copy link
Contributor

bdice commented Dec 2, 2024

Private methods (those starting with an underscore) are not considered to be part of the stable/public API. In the future, we will provide public pylibcudf APIs as a means to handle lower-level interoperation between libcudf and cuDF's Python layer. We have a few open issues related to this request:

We are hoping to have these features in the public API for the 25.02 release.

@martindurant
Copy link
Author

Please keep me updated - I hope we will not have to change too much. To be sure: this functionality was available without a "_" method in the previous release.

@vyasr
Copy link
Contributor

vyasr commented Dec 3, 2024

For the moment if you need to use that method, please continue to do so. Everything related to cuDF Column objects falls into the unfortunate bucket of parts of cuDF that were intended to be internal but were public and useful enough that various libraries started to use them. We unfortunately do not yet have the public APIs in place to replace existing functionality because we do not yet have a full scope of what projects have been relying on that we did not intend them to. #17317 is where we will be discussing the next steps, so please feel free to comment there and let us know what are all the functions that you are accustomed to performing directly on cuDF Column objects and we will take that into account as we work on our internal redesign. My expectation is that pylibcudf will satisfy many if not most of the current needs, but I also anticipate that there will continue to be some use cases where users need to interact directly with cuDF Column objects (such as for introducing custom dtypes). At present we have put a lot more thought into pylibcudf's API than how exactly cuDF internals will look once pylibcudf is ready, but that will be changing in the next 2-4 months.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Documentation question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants