[SURE-9311] Fleet's gitrepoJobsCleanup not disabled when continuous-delivery (Gitops) feature is off

[kkaempf]

SURE-9311

Request description:

We have the continuous-delivery feature turned off on our rancher installation. When upgrading to rancher v2.9.3 (fleet v0.10.4) a new cronjob is created on the local cluster that generate failing jobs.

We've been able to turn off the cronjob creation by specifying "fleet" values in rancher's chart (i.e.: https://github.com/rancher/rancher/blob/main/chart/values.yaml#L200) and it all seems fine, but the warning about "override all other global values" might cause issues in later versions...

Would it be possible to set the default fleet chart value for migrations.gitrepoJobsCleanup based on the feature flag? Same way it is for the feature itself here: https://github.com/rancher/rancher/blob/main/pkg/controllers/dashboard/fleetcharts/controller.go#L121

Actual behavior:

Fleet cronjobs being created when fleet is disabled

Expected behavior:

No fleet cronjobs being created when fleet is disabled.

Workaround:

Is a workaround available and implemented? yes
What is the workaround:

We've been able to turn off the cronjob creation by specifying "fleet" values in rancher's chart (i.e.: https://github.com/rancher/rancher/blob/main/chart/values.yaml#L200) and it all seems fine, but the warning about "override all other global values" might cause issues in later versions...