Try evaluating code with parentheses before without parentheses #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramnathv#356. The problem with evaluating without parentheses first is that named function declarations are valid expressions that return undefined (whereas evaluating with parentheses returns the function, as expected). It's true there may be weird corner-cases where switching this order leads to something else that's undesirable, but we've been operating with the 'with parentheses' model for so long that switching the ordering now will minimize backward-compatibility issues
|
A test for this functionality is here rstudio/shiny-examples#177 |
schloerke
added a commit
to schloerke/htmlwidgets
that referenced
this pull request
Sep 30, 2020
* upstream/master: Bump dev version Export JSEvals (ramnathv#381) Add missing roxygenize step (ramnathv#370) Add reportTheme arg to shinyWidgetOutput() (ramnathv#361) Try evaluating code with parentheses before without parentheses, closes ramnathv#356. (ramnathv#357) Bump version for development v1.5.1 release candidate (ramnathv#353) Add a comment; abstract out duplication in logic (ramnathv#354) Prevent staticRender from being called unconditionally when htmlwidgets.js is loaded after page load Bump version; update NEWS Use to schedule staticRender() iff jQuery 3 or higher is present in shinyMode Bump version Bump version for release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #356.
The problem with evaluating without parentheses first is that named function declarations are valid expressions that return undefined (whereas evaluating with parentheses returns the function, as expected).
It's true there may be weird corner-cases where switching this order leads to something else that's undesirable, but we've been operating with the 'with parentheses' model for so long that switching the ordering now will minimize backward-compatibility issues