Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility_level config #1250

Open
slavad opened this issue Oct 18, 2024 · 3 comments
Open

Add compatibility_level config #1250

slavad opened this issue Oct 18, 2024 · 3 comments

Comments

@slavad
Copy link

slavad commented Oct 18, 2024

Issue

You can't specify compatibility_level in the db config

Expected behavior

You should be able to do this

Actual behavior

If I add compatibility_level: 130 in database.yml, it's ignored, the compatibility level is set to 140 (default for my db version)

How to reproduce

Add compatibility_level: 130 to the db config in database.yml

Details

  • Rails version: n/a
  • SQL Server adapter version: n/a
  • TinyTDS version: n/a
  • FreeTDS details: n/a

I forked the repo and added this feature. Is it ok if I create a pull request?

The feature branch was branched off the tag v7.2.1

@aidanharan
Copy link
Contributor

@slavad Why would you change the compatibility level of a database when you connect to it? If it's a once off task then doing it manually would be better.

@slavad
Copy link
Author

slavad commented Oct 20, 2024

@aidanharan no, the compatibility level would be set during creation.

The compatibility_level setting would work like the collation setting (both in database.yml)

@slavad
Copy link
Author

slavad commented Oct 25, 2024

@aidanharan check this out #1254

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants