Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performing search with character '#' returns all results #71

Open
AtomicMaya opened this issue May 28, 2022 · 3 comments
Open

Performing search with character '#' returns all results #71

AtomicMaya opened this issue May 28, 2022 · 3 comments

Comments

@AtomicMaya
Copy link

Describe the bug
When searching for a user, a team name, etc. performing a search using the search field for any text that includes the pound sign # returns all results.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Admin/Teams
  2. Search for #<An existing team name>
  3. See error (all teams in order of registration are displayed)

Expected behavior
The results should be only the names containing the characters in the search field.

Screenshots
image

Environment (please complete the following information):
N/A

@thebeanogamer
Copy link
Member

This appears to be a Shell issue. Search strings get truncated at the #, Core is correctly replying to the query.

Searching for asd#asd causes a request to https://api-XXX.ractf.cloud/api/v2/member/?search=asd.

@AtomicMaya
Copy link
Author

Can confirm that only first part of string is used.

@NicholasG04
Copy link
Member

We will URL encode this, should fix it probably maybe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants