Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quick test of upcoming 3D viewer #108

Open
wiesehahn opened this issue Jan 2, 2025 · 5 comments
Open

quick test of upcoming 3D viewer #108

wiesehahn opened this issue Jan 2, 2025 · 5 comments
Assignees
Labels
devel Development branch

Comments

@wiesehahn
Copy link

I had a quick glimpse at the 3D viewer in v 0.14 (devel) under windows 11.

some observations:

  • progress bar for LoD generation ends at 99% while viewer opens in the background. Possibly better to print a message that viewer is ready, or always bring window to front when ready.

  • colors are shown in discrete steps for small differences (e.g. flat terrain), possibly color palette could be extended with more colors, or min and max could be calculated based on points in viewport instead of full pointcloud.

Screenshot 2025-01-02 110014

  • when zooming in, one mouse wheel rotation has less and less effect, while this might make sense to a certain degree the effect is too heavy in my opinion. In the current state it becomes unusable at a certain point at which it is unpossible to zoom out again and also to pan around the map.
  • the scene in the 3D viewer is heavily flickering most of the time
Bildschirmaufnahme.2025-01-02.112402.mp4
Bildschirmaufnahme.2025-01-02.112508.mp4
@Jean-Romain
Copy link
Collaborator

Thank you for your feedback.

Progress bar for LoD generation ends at 99%.

Ok, easy to fix.

Possibly better to print a message that the viewer is ready, or always bring the window to the front when ready.

We have the same problem with the lidR rgl viewer on Windows. It opens in the background, which is not very convenient. I do not have this issue on Linux; the window is always opened in front both in lidR and lasR.

Colors are shown in discrete steps for small differences (e.g., flat terrain). Possibly the color palette could be extended with more colors, or min and max could be calculated based on points in the viewport instead of the full point cloud.

Certainly. Easy to fix. More generally, I still have some work to do on colors.

When zooming in, one mouse wheel rotation has less and less effect.

I know this one. I will fix it.

The scene in the 3D viewer is heavily flickering most of the time.

This is not normal. It is not flickering on Linux. Surprisingly, you did not report this issue for lidRviewer, which uses pretty much the same code. This is (1) Windows-specific and (2) due to something different than in lidRviewer. Well, that one won't be easy to fix.

@wiesehahn
Copy link
Author

We have the same problem with the lidR rgl viewer on Windows. It opens in the background, which is not very convenient. I do not have this issue on Linux; the window is always opened in front both in lidR and lasR.

in lidR it might be possible to fix this with rgl.bringtotop()

This is not normal. It is not flickering on Linux. Surprisingly, you did not report this issue for lidRviewer, which uses pretty much the same code. This is (1) Windows-specific and (2) due to something different than in lidRviewer. Well, that one won't be easy to fix.

exactly, lidRviewer does not have the problem

@Jean-Romain
Copy link
Collaborator

Jean-Romain commented Jan 2, 2025

  • Improve color palettes
  • Fix progress bar to 100%
  • Open the windows in foreground
  • Fix zoom and pan
  • Fix flickering on Windows

@Jean-Romain Jean-Romain added the devel Development branch label Jan 2, 2025
@Jean-Romain Jean-Romain self-assigned this Jan 2, 2025
@Jean-Romain
Copy link
Collaborator

I fixed 3 points. The zoom is no longer infinite and stops at a certain level. Zoom sensitivity is no longer linear. Pan sensitivity has been updated to be more comfortable. The windows should open in foreground on windows. However I did not fix the flickering yet. On my virtual box the viewer is black and display nothing 😞

@wiesehahn
Copy link
Author

Zoom is better, but I think it could be stronger/faster/more responsive (more zoom per mouse wheel rotation). Currently we have to keep scrolling quite long to get fully in.

Panning around seems to work ok, but it feels a little laggy.

The first time we plot a pointcloud in a R session it opens in the background, the following times in the foreground.

Progress is up to 100% but the following message "NULL no progress" might be irritating.

Regarding the flickering, as long as we keep constantly panning or rotating around the scene there is no flickering, but when we zoom or do nothing there is heavy flickering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devel Development branch
Projects
None yet
Development

No branches or pull requests

2 participants