Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation check #267

Open
hadley opened this issue Mar 29, 2021 · 7 comments
Open

Documentation check #267

hadley opened this issue Mar 29, 2021 · 7 comments
Labels
blocked Blocked by an issue elsewhere feature a feature request or enhancement

Comments

@hadley
Copy link
Member

hadley commented Mar 29, 2021

  • Run roxygen2::roxygenise() and check no files changed
  • Check that pkgdown::build_reference_index() is ok
  • Spellcheck?
  • URL check?
@hadley
Copy link
Member Author

hadley commented Mar 29, 2021

Look at what Shiny does.

@gaborcsardi
Copy link
Member

Do you still want these as separate actions? Or as an example workflow that does all of them?

@gaborcsardi gaborcsardi added the feature a feature request or enhancement label Dec 10, 2021
@hadley
Copy link
Member Author

hadley commented Dec 10, 2021

Let's wait for @schloerke since this is something that Shiny already does.

We should also think about compiling translation files .mo as part of this step.

@gaborcsardi
Copy link
Member

gaborcsardi commented Oct 19, 2022

Hadley, do you still want an action and/or workflow for these?

TBH it does not seem practical to introduce new jobs for these.

  • Maybe the roxygen2::roxygenise() check could be part of the check-r-package action?
  • pkgdown we already "check" in the pkgdown action, which now also runs for PRs
  • Spellcheck could be also part of the check-r-package action, optionally.
  • We could turn on URL checks in R CMD check, or run the URL checks as part of the check-r-package action.

@hadley
Copy link
Member Author

hadley commented Oct 19, 2022

Yeah, I think the best way to handle these would be to introduce additional features/functions in rcmdcheck, and then set those options for actions.

@gaborcsardi
Copy link
Member

This is blocked by new features in rcmdcheck.

@AlexAxthelm
Copy link

Our team has a pretty simple workflow that we call that has been handling our needs for this
https://github.com/RMI-PACTA/actions/blob/main/.github/workflows/R-check-docs.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Blocked by an issue elsewhere feature a feature request or enhancement
Projects
None yet
Development

No branches or pull requests

3 participants