Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build/publish script refactor #69

Open
eritbh opened this issue Jul 8, 2020 · 1 comment
Open

Build/publish script refactor #69

eritbh opened this issue Jul 8, 2020 · 1 comment
Assignees

Comments

@eritbh
Copy link
Member

eritbh commented Jul 8, 2020

  • Use Github Actions instead of Travis to keep tings centralized
  • Make sure the build/verification portion of the script can be run locally without requiring Reddit credentials
  • Use dart-sass on the command line as the standard for sass compilation (will allow the use of new language features faster, libsass is kinda slow) + document this in readme
    • Use new --no-charset dart-sass CLI flag to avoid having to strip that out manually in the build
    • Explore performance of --style=compressed dart-sass option compared to the currently used CSS compression API
@eritbh
Copy link
Member Author

eritbh commented Oct 10, 2021

Another thing to address - we should probably just remove the validation step, it's unlikely to be helpful since Reddit's CSS rules are all we really care about and are stricter than w3c's most of the time.

I'm not sure how much of this issue is still relevant after #77 - need to go over this again at some point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant