Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we add unknown sequences variants? #19

Open
zrzka opened this issue Nov 29, 2019 · 0 comments
Open

Should we add unknown sequences variants? #19

zrzka opened this issue Nov 29, 2019 · 0 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@zrzka
Copy link
Collaborator

zrzka commented Nov 29, 2019

Version 0.1.6 provides:

pub enum Sequence {
    Key(KeyCode, KeyModifiers),
    Mouse(Mouse, KeyModifiers),
    CursorPosition(u16, u16),
}

Parser throws away every csi/esc sequence without known meaning (valid sequence, but we have no idea what it is). What's the problem. Any sequence, which isn't supported by anes is trashed and crate user doesn't even know it. Is this something we should expose? Should we add Sequence::UnknownEsc(char) & Sequence::UnknownCsi(Vec<u64>, usize, char)?

@zrzka zrzka added enhancement New feature or request question Further information is requested and removed enhancement New feature or request labels Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant