-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
أين نقلت الملفات غير الصوتية #2986
Comments
نعم - هذا صحيح. الإصدارات الجديدة من أندرويد تمنع إستخدام الأماكن على الذاكرة الخارجية إلى في أماكن محددة. (answering in English for the benefit of those who speak English) consequently, the default storage location for the app became internal storage. we do understand that many people want to use the audio files outside of the application, and, as thus, there's an option for moving the audio files into the allowed app specific folder in external storage (typically جزاكم الله خيراً |
أفهم ذلك ولكن هذا سيمنع من إرسال الملفات الخاصة بالصفح والتفسير والترجمة إلى أجهزة أخرى وسأضطر لتحميلها باستخدام الإنترنت لكن هذه أحجام صغيرة جيد أن ملفات الصوت بقيت بالخارج لأن أحجامها كبيرة جدا شكرًا لذلك. |
@ahmedre Why is the database location not also in /Android/data/com.quran.labs.androidquran/files |
@KhaledKhaled0909 (in English)
|
@AlbahrawyTiger it used to be historically as part of the original "everything lives in /sdcard/quran_android" approach. This got migrated to "everything lives in /Android/data/com.quran.labs.androidquran.data" in previous releases. in this release, however, it seemed the right time to keep these databases and page types internal for a few reasons:
|
@ahmedre |
@ahmedre هل ممكن نعمل workflow وايضا هذه الأيام الهواتف تاني بذاكره كبيره نسبيا فلم بعد حجم التطبيق عائق. |
وعليكم السلام ورحمة الله وبركاته |
@ahmedre Can this be kept original for the entire database, it is a good option for those who have not rooted their device to access the database in Android/data |
Here are my thoughts on this - the intention is to keep files people might need to use outside of the app (mp3s which are playable in mp3 players outside of the Qur'an app) in a place accessible on external storage (Android/data). The databases and pages are an implementation detail of the app and. aren't usable outside of the app, so they make sense on internal storage. The only usage of the database and pages are someone building their own app, and this is not how I want to give the data to them - people taking the data from the application's files and putting them in another app lose updates and fixes and the ability to remove problematic translations, etc. There are better ways to provide this data to app developers (ex the Quran.com api, etc). I think Khaled's use case of "giving an entire ready to use app to a friend," while great, is a rare case (and, even if so, we can fix most of this problem by bundling the pages with the app in the future in sha' Allah). That just leaves the databases for translations then. I am curious as to what the use case is that makes these files (which are an implementation detail) needed. |
@ahmedre I am not a developer, I have my own use cases that I mention, for example: I want to copy verses of the Qur’an with the orthography (الإملائي) Imlaei (Simple), so I replace the quran.ar.uthmani.v2.db base with a base that has the Qur’an in the text Imlaei (Simple) (الإملائي), and I have an example Another: I am moving some translation rules to another application folder that uses the same Quran Android database system. On the occasion of our brother Khaled’s suggestion, I suggest including the textual presentation of the Quran (With text wrapping system) Instead of Quran images, this text display system can provide initial application launch and Quran reading without having to download Quran images (for those who want) and also not increase the apk size. Greentech Apps Foundation has implemented this beautifully but it is not open source. Also our brother irfan implements a text wrapping system for the Qur’an, which is open source, but does not support audio. https://play.google.com/store/apps/details?id=com.mirfatif.noorulhuda https://github.com/mirfatif/NoorUlHuda Related Issue I opened جزى الله خيرا كل من ساهم وبارك عليهم |
I tried copying the same verse from the two apps the quran for android app here the text does not look correct like the نور هدى app you mentioned which was the resson that devolpers here change the font of the tafsir section from the device font to a unified font but the problem still there when you copy any verse from the app and paste it on any where else. |
@KhaledKhaled0909 المشكلة في خط الهاتف لديك، عليك تغييره |
@AlbahrawyTiger |
The first one at least is a good candidate for a feature built into the app - i.e. share uthmani text or imlaei text. At the same time, I think we used to have this option long ago and removed it because we got a lot of complaints that "the Qur'an should only be written in Uthmani text and it's wrong to share it in Imlaei text" - but not sure, can double check this with a sheikh and ask. We just got a request for it in #3028 the other day also.
This was a long discussion many times in the past - it's a good idea, but has some drawbacks that make things difficult. First and foremost, getting things correct on all devices was a very difficult task in earlier days of Android, where some device overwrite whatever font settings are put, etc. Until recently, I've seen glitches on Tarteel (which does use fonts also) during the beta days of Android 15, and saw a good number of "Quran.com misrenders the text on Safari" issues on the bug tracker and Discord. Images are much safer for that reason. Some more reasons:
All and all, it's a valid idea but I avoided this to avoid the maintenance costs of people with rendering issues.
I think (I might be remembering wrong can double check) that we actually have 2 "flavors" of the uthmani text - that which we show in the app (full text with everything) and the "minimal version" that we use for sharing (much less tashkeel, etc). we can't control how apps outside of ours render things so that makes it tricky to fix this type of thing, and many of the pre-installed system fonts don't support the complex characters used in uthmani rendering. |
@ahmedre |
I think data here represent public data of app that other apps can read, in our case still we store them internally so no other app can read, so this share app won't able to share app with data. Am I right @ahmedre |
لا أجد ملفات التطبيق في أي مكان ولا تقل لي إنها نقلت إلى user folder الذي لا يمكن الوصول له بدون روت!
The text was updated successfully, but these errors were encountered: