Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to play a hizb easily (will be useful when revising memorizations) #677

Open
imthath-m opened this issue Dec 8, 2024 · 2 comments

Comments

@imthath-m
Copy link

Usecase: When memorizing long surahs, after memorzing page by page, I try to revise hizb by hizb. It will be helpful if I can play the audio for a hizb easily.

Current workaround:

  • I open the page where the hizb begins
  • Tap "Play" (at bottom left corner)
    • If hizb begins in the middle of the page, press and hold the first ayah and then tap "Play" in the context menu
  • Tap "Modify"
  • Tap "To"
  • Scroll to the ending ayah of the hizb (which I should have noted down already)
  • Tap that ayah.
  • Tap "Play" (at top right corner)

Proposed solutions:
In the below "Juz" view where a list of hizb rows are displayed, we can add one of the following two options.

  1. Add a play button above the page number for each row. Single tap to play the full hizb.
  2. Add a play button inside a context menu, which appears when I tap and hold a hizb row.

IMG_5955

I would like to contribute to the code if you can give me some pointers about where to work for this feature.

@mohamede1945
Copy link
Collaborator

Wa alaykum as-salam wa rahmatullahi wa barakatuh,

I believe I understand the issue, but I’m not sure the proposed solutions align with the approach we would take. So far, audio playback has been handled within the Quran UI rather than the main navigation views, and I don’t think I would expose it externally without a proper framework.

That said, I think adding an option to play until the end of a Hizb, similar to what we have for Page, Surah, and Juz', should be fine in my opinion.

@imthath-m
Copy link
Author

audio playback has been handled within the Quran UI rather than the main navigation views
Does that mean that we should not change it? It is not mandatory everyone who listens to the audio of the Quran is also looking at the screen and reading it. So IMO, the premise that you have to open the Quran Reader UI and then play the audio is not ideal.

I understand that there are other apps are only audio but in most cases they let you play only entire surahs. For fine grained playback, this app is helpful and I would appreciate if that experience can be improved further.

I think adding an option to play until the end of a Hizb, similar to what we have for Page, Surah, and Juz', should be fine in my opinion.

That will be helpful but still not ideal because if a Hizb starts in the middle of a page, there will be multiple taps required to update the starting verse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants