Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[discuss] stage 3 proposals, yay or nay? #670

Open
bnoordhuis opened this issue Nov 10, 2024 · 6 comments
Open

[discuss] stage 3 proposals, yay or nay? #670

bnoordhuis opened this issue Nov 10, 2024 · 6 comments
Labels
enhancement New feature or request

Comments

@bnoordhuis
Copy link
Contributor

bnoordhuis commented Nov 10, 2024

Did we ever settle on a policy on what to add when?

There's https://github.com/tc39/proposal-arraybuffer-base64 that I'd like to implement because:

  1. it seems useful1
  2. it is at stage 3
  3. it is covered by test262 (feature uint8array-base64)
  4. it is always nice to beat V8 on features :)

1 Lets me remove the hand-rolled base64 parser I added in a1d1bce

@bnoordhuis bnoordhuis added the enhancement New feature or request label Nov 10, 2024
@saghul
Copy link
Contributor

saghul commented Nov 11, 2024

I'm game 👍

@saghul
Copy link
Contributor

saghul commented Nov 11, 2024

I guess we could also use parse for atob?

@bnoordhuis
Copy link
Contributor Author

If and when we implement that, yes :-)

I said in #16 I see no problem with adding DOMException but it kinda is slippery-sloping into web territory.

@saghul
Copy link
Contributor

saghul commented Nov 11, 2024

Right. We could have some "minimal web API helpers" thing perhaps?

Or we can just have those be implemented by embedders and that's that.

IIRC bjson already exports everything necessary for implementing structuredClone...

Shall we close #16?

@bnoordhuis
Copy link
Contributor Author

I don't know, the argument that every embedder ends up implementing them anyway is still valid.

I'll work on arraybuffer-base64 and if afterwards atob turns out to be very easy to layer on top, then I guess we might as well do it. Given the choice, most users will probably pick more features over fewer features.

@saghul
Copy link
Contributor

saghul commented Nov 11, 2024

Good point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants