Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review Feedback, Form and other control apis design. #45

Open
metasansana opened this issue Jun 12, 2020 · 2 comments
Open

Review Feedback, Form and other control apis design. #45

metasansana opened this issue Jun 12, 2020 · 2 comments

Comments

@metasansana
Copy link
Collaborator

APIs like setMessage() and setValidationState() were designed with a specific project in mind. Now that we have more experience with this library, it may be a good idea to review how these are implemented, make them more consistent and fun to work with.

@metasansana
Copy link
Collaborator Author

The setValidataionState() should probably be kept, there are times we need to change the state of the control without setting a message. However instead of having to do setMessage(msg) then setValidationState(), it would be easier to just call setErrorMessage(msg) or something to that effect.

@metasansana
Copy link
Collaborator Author

Buttons should not be generic. Clicking on a button should fire an event but not provide a value. If a value needs to be provided use a closure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant