updater: Support max entry size in offline vuln load #1304
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows clients to control the size of the offline importer entries. Up until now, the entry size was determined by the reference ID. Some updaters (eg. RHEL) fetch huge pages of vulnerabilities from their security source (eg. OVAL XML) into memory, and the JSON blob storage will give them the same reference ID, forcing clients to have enough memory to load them.
Other alternatives are possible, but I concluded that this one was less intrusive and had the lowest impact on existing clients.
Returning multiple entries with the same fingerprint should be OK as long the clients are the only ones performing the updates, and the state of the operations is retrieved before updating, which is what the offline importer does