Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updater: Support max entry size in offline vuln load #1304

Closed
wants to merge 1 commit into from

Conversation

jvdm
Copy link
Contributor

@jvdm jvdm commented Apr 5, 2024

This PR allows clients to control the size of the offline importer entries. Up until now, the entry size was determined by the reference ID. Some updaters (eg. RHEL) fetch huge pages of vulnerabilities from their security source (eg. OVAL XML) into memory, and the JSON blob storage will give them the same reference ID, forcing clients to have enough memory to load them.

Other alternatives are possible, but I concluded that this one was less intrusive and had the lowest impact on existing clients.

Returning multiple entries with the same fingerprint should be OK as long the clients are the only ones performing the updates, and the state of the operations is retrieved before updating, which is what the offline importer does

@jvdm jvdm requested a review from a team as a code owner April 5, 2024 02:10
@jvdm jvdm requested review from hdonnay, crozzy and RTann and removed request for a team April 5, 2024 02:10
Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.82%. Comparing base (813e7cc) to head (5149ac2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1304      +/-   ##
==========================================
+ Coverage   55.78%   55.82%   +0.03%     
==========================================
  Files         265      265              
  Lines       16547    16557      +10     
==========================================
+ Hits         9231     9243      +12     
+ Misses       6357     6356       -1     
+ Partials      959      958       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jvdm jvdm force-pushed the jvdm/horizontal branch 2 times, most recently from c17186d to 2d78ae3 Compare April 5, 2024 22:53
@jvdm jvdm changed the title feat: Support max entry size in offline vuln load updater: Support max entry size in offline vuln load Apr 5, 2024
@jvdm jvdm force-pushed the jvdm/horizontal branch from 2d78ae3 to ee6f65e Compare April 8, 2024 20:38
@jvdm jvdm force-pushed the jvdm/horizontal branch from ee6f65e to 5149ac2 Compare April 10, 2024 22:34
@jvdm jvdm closed this Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant