Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The name of the variable "VOS" does not follow Panlint requirements #234

Open
Pansanel opened this issue May 11, 2020 · 4 comments
Open
Labels
Milestone

Comments

@Pansanel
Copy link
Contributor

The name of the variable called "VOS" is too short. Panlint required to have at least 5 characters. I would propose to rename VOS by ENABLED_VOS.

@jrha
Copy link
Member

jrha commented Apr 12, 2021

As a side-note we have been using SUPPORTED_VOS here at RAL.

@Pansanel
Copy link
Contributor Author

Pansanel commented Apr 12, 2021

@jrha SUPPORTED_VOS sounds good to me!

@jouvin
Copy link
Contributor

jouvin commented Nov 8, 2024

Very late comment... I'm reluctant to this change as VOS is used everywhere in the templates... Can we defined a panlint exception at variable definition time? Or would panlint complain at every use of the variable?

@jrha
Copy link
Member

jrha commented Nov 8, 2024

I'd argue that it's worth changing regardless of what panlint says, VOS doesn't provide much meaning and sed is easy to use…

@jrha jrha added this to the 25.next milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

3 participants