Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 - GetURL returns path if Endpoint set #15

Open
linchpinstudios opened this issue Jan 24, 2020 · 0 comments
Open

S3 - GetURL returns path if Endpoint set #15

linchpinstudios opened this issue Jan 24, 2020 · 0 comments

Comments

@linchpinstudios
Copy link

This seems like unexpected behavior but I wanted to make sure.

It appears as though if the Endpoint is set or the ACL is set to a BucketCannedACLPrivate or s3.BucketCannedACLAuthenticatedRead the interface will return the path that was passed in.

Storage.GetURL(obj.Src) // returns obj.Src

Expected behavior:

If Endpoint is set it would return {Endpoint}{path} or if there is no endpoint and public ACL it would return the standard URL for the S3 bucket Region.

I'd be happy to make a pull request for this functionality, but I would like to make sure this is the expected behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants