Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if we need to remove retries in tryCommand #77

Open
qnikst opened this issue Dec 22, 2020 · 0 comments
Open

Check if we need to remove retries in tryCommand #77

qnikst opened this issue Dec 22, 2020 · 0 comments

Comments

@qnikst
Copy link
Owner

qnikst commented Dec 22, 2020

We retry each command several times. Such code always look very suspicious and it seems as it hides potential
problems. I've tried to follow the reasons for adding that, but it was a part of a big commit:

024f647

So currently I'm in doubts: removing it will make code cleaner but it could be possible that some systems depend on it and may fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant