From fe0373235e2718528d25af1fb84a713188b1daad Mon Sep 17 00:00:00 2001
From: "k.sidorov" <k.sidorov@qiwi.com>
Date: Tue, 6 Aug 2019 10:54:50 +0300
Subject: [PATCH] [NF] @role for elements Accordion, Content, Breadcrumbs

---
 packages/desktop/src/block-accordion/BlockAccordion.tsx | 3 +++
 packages/desktop/src/block-content/BlockContent.tsx     | 2 ++
 packages/desktop/src/breadcrumbs/Breadcrumbs.tsx        | 2 +-
 packages/mobile/src/block-accordion/BlockAccordion.tsx  | 2 ++
 packages/mobile/src/block-content/BlockContent.tsx      | 2 ++
 5 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/packages/desktop/src/block-accordion/BlockAccordion.tsx b/packages/desktop/src/block-accordion/BlockAccordion.tsx
index 69761e327..e0657974a 100644
--- a/packages/desktop/src/block-accordion/BlockAccordion.tsx
+++ b/packages/desktop/src/block-accordion/BlockAccordion.tsx
@@ -29,6 +29,7 @@ export const BlockAccordion: FunctionComponent<
   BlockAccordionProps<BlockAccordionItemModel>
 > = ({items, indent = 'm', tabIndex = 0, opened, onChange}) => (
   <AccordionControl<BlockAccordionItemModel>
+
     items={items}
     opened={opened}
     onChange={onChange}
@@ -37,6 +38,8 @@ export const BlockAccordion: FunctionComponent<
         {renderProps.items.map((item, index) => (
           <Card
             key={index}
+            role="article"
+            aria-label={typeof item.title === 'string' ? item.title : undefined}
             s={
               item.hovered || item.focused
                 ? '0 0 16px 0 rgba(0, 0, 0, 0.12)'
diff --git a/packages/desktop/src/block-content/BlockContent.tsx b/packages/desktop/src/block-content/BlockContent.tsx
index f6c5948b4..bbecaabd7 100644
--- a/packages/desktop/src/block-content/BlockContent.tsx
+++ b/packages/desktop/src/block-content/BlockContent.tsx
@@ -14,6 +14,8 @@ const BlockContentIdent: { [indent in NonNullable<BlockContentProps['indent']>]:
 
 export const BlockContent: FC<BlockContentProps> = ({indent = 'm', children}) => (
   <Box
+    role="section"
+    aria-label="content"
     p={BlockContentIdent[indent]}
     children={children}
   />
diff --git a/packages/desktop/src/breadcrumbs/Breadcrumbs.tsx b/packages/desktop/src/breadcrumbs/Breadcrumbs.tsx
index eff04762f..dc86abfc7 100644
--- a/packages/desktop/src/breadcrumbs/Breadcrumbs.tsx
+++ b/packages/desktop/src/breadcrumbs/Breadcrumbs.tsx
@@ -13,7 +13,7 @@ export const Breadcrumbs: FC<BreadcrumbsProps> = ({children}) => (
       <Fragment key={i} >
         {i > 0 ? (
           <Fragment>
-            <Box as="span" mx={2} display="inline">
+            <Box as="span" mx={2} display="inline" role="section">
               &#8226;
             </Box>
             &shy;
diff --git a/packages/mobile/src/block-accordion/BlockAccordion.tsx b/packages/mobile/src/block-accordion/BlockAccordion.tsx
index 6a717dde3..f8262062b 100644
--- a/packages/mobile/src/block-accordion/BlockAccordion.tsx
+++ b/packages/mobile/src/block-accordion/BlockAccordion.tsx
@@ -28,6 +28,8 @@ export const BlockAccordion: FunctionComponent<
         {renderProps.items.map((item, index) => (
           <Card
             key={index}
+            role="article"
+            aria-label={typeof item.title === 'string' ? item.title : undefined}
             s={
               index > 0
                 ? '0 -1px 0 #e6e6e6'
diff --git a/packages/mobile/src/block-content/BlockContent.tsx b/packages/mobile/src/block-content/BlockContent.tsx
index 200b04a43..22a565a26 100644
--- a/packages/mobile/src/block-content/BlockContent.tsx
+++ b/packages/mobile/src/block-content/BlockContent.tsx
@@ -13,6 +13,8 @@ const BlockContentIdent: { [indent in NonNullable<BlockContentProps['indent']>]:
 
 export const BlockContent: FC<BlockContentProps> = ({indent = 'm', children}) => (
   <Box
+    role="section"
+    aria-label="content"
     p={BlockContentIdent[indent]}
     children={children}
   />