Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Model fitting is broken with scipy 1.15 #2666

Closed
Balandat opened this issue Jan 3, 2025 · 0 comments
Closed

[Bug] Model fitting is broken with scipy 1.15 #2666

Balandat opened this issue Jan 3, 2025 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@Balandat
Copy link
Contributor

Balandat commented Jan 3, 2025

🐛 Bug

Model fitting fails in scipy 1.15 (see test failure here: see e.g. https://github.com/pytorch/botorch/actions/runs/12601444508), presumably b/c L-BFGS-B was ported to C: https://scipy.github.io/devdocs/release/1.15.0-notes.html#scipy-optimize-improvements

#2665 pins scipy to <1.15 to avoid test failures in CI for the time being, but we need to root cause and fix it in a way that's compatible with both <1.15 and 1.15+.

@Balandat Balandat added the bug Something isn't working label Jan 3, 2025
@Balandat Balandat self-assigned this Jan 3, 2025
Balandat added a commit to Balandat/botorch that referenced this issue Jan 4, 2025
Resolves pytorch#2666 by updating the regexp that is used to filter out the optimization warning emitted when the maximium number of iterations is reached.

NOTE: This kind of regexp filtering is kind of brittle, but it's not necessarily obvious how to do this differently if scipy doesn't return these in a more structured form.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant