Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

threading.local() access should scale well from multiple threads #128691

Closed
colesbury opened this issue Jan 9, 2025 · 0 comments
Closed

threading.local() access should scale well from multiple threads #128691

colesbury opened this issue Jan 9, 2025 · 0 comments
Labels
performance Performance or resource usage topic-free-threading type-feature A feature request or enhancement

Comments

@colesbury
Copy link
Contributor

colesbury commented Jan 9, 2025 •
edited by bedevere-app bot
Loading

Currently, accessing a threading.local() from multiple threads doesn't scale well because of reference count contention on the shared _thread._local object. We should use deferred reference counting on _thread._local to avoid this bottleneck.

Linked PRs
@colesbury colesbury added performance Performance or resource usage topic-free-threading labels Jan 9, 2025
colesbury added a commit to colesbury/cpython that referenced this issue Jan 9, 2025
@colesbury
pythongh-128691: Use deferred reference counting on _thread._local
af23793 
After this change, the "thread_local_read" micro benchmark in
Tools/ftscalingbench/ftscalingbench.py now scales well when multiple
threads read from the same thread-local variable.
colesbury added a commit to colesbury/cpython that referenced this issue Jan 9, 2025
@colesbury
pythongh-128691: Use deferred reference counting on _thread._local
cc0e189 
After this change, the "thread_local_read" micro benchmark in
Tools/ftscalingbench/ftscalingbench.py now scales well when multiple
threads read from the same thread-local variable.
colesbury added a commit to colesbury/cpython that referenced this issue Jan 9, 2025
@colesbury
pythongh-128691: Use deferred reference counting on _thread._local
a8c2e44 
This change, along with the LOAD_ATTR specializations, makes the
"thread_local_read" micro benchmark in Tools/ftscalingbench/ftscalingbench.py
scale well to multiple threads.
@colesbury colesbury added the type-feature A feature request or enhancement label Jan 9, 2025
@bedevere-app bedevere-app bot mentioned this issue Jan 9, 2025
Merged
colesbury added a commit to colesbury/cpython that referenced this issue Jan 10, 2025
@colesbury
Merge branch 'main' into pythongh-128691-thread-local-deferred
2a328af
@colesbury colesbury changed the title threading.local() access should scale well threading.local() access should scale well from multiple threads Jan 10, 2025
colesbury added a commit that referenced this issue Jan 10, 2025
@colesbury
gh-128691: Use deferred reference counting on _thread._local (#128693)
c141748 
This change, along with the LOAD_ATTR specializations, makes the
"thread_local_read" micro benchmark in Tools/ftscalingbench/ftscalingbench.py
scale well to multiple threads.
hugovk added a commit to hugovk/cpython that referenced this issue Jan 12, 2025
@hugovk
Revert "pythongh-128691: Use deferred reference counting on `_thread.…
df78b24 
…_local` (python#128693)"

This reverts commit c141748.
hugovk added a commit to hugovk/cpython that referenced this issue Jan 12, 2025
@hugovk
Revert "pythongh-128691: Use deferred reference counting on `_thread.…
26de5be 
…_local` (python#128693)"

This reverts commit c141748.
@bedevere-app bedevere-app bot mentioned this issue Jan 12, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance Performance or resource usage topic-free-threading type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@colesbury