Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NOT_TAKEN instructions need to be added after optimization #128533

Closed
Tracked by #122548
markshannon opened this issue Jan 6, 2025 · 0 comments
Closed
Tracked by #122548

NOT_TAKEN instructions need to be added after optimization #128533

markshannon opened this issue Jan 6, 2025 · 0 comments
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) type-feature A feature request or enhancement

Comments

@markshannon
Copy link
Member

markshannon commented Jan 6, 2025 •
edited by bedevere-app bot
Loading

The NOT_TAKEN instruction is added during code gen, but can be left when jumps are removed by the optimizer.

We should probably add the NOT_TAKEN instructions in the assembler after optimization, as suggested in #122564 (comment)

Linked PRs
@markshannon markshannon mentioned this issue Jan 6, 2025
Open
@picnixz picnixz added type-feature A feature request or enhancement interpreter-core (Objects, Python, Grammar, and Parser dirs) labels Jan 6, 2025
@bedevere-app bedevere-app bot mentioned this issue Jan 6, 2025
Merged
@markshannon markshannon changed the title NOT_TAKEN instructions need to added after optimization NOT_TAKEN instructions need to be added after optimization Jan 6, 2025
markshannon added a commit that referenced this issue Jan 6, 2025
@markshannon
GH-128533: Add NOT_TAKEN instruction after bytecode optimization. (G…
2434fd2 
…H-128554)
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this issue Jan 8, 2025
@markshannon @srinivasreddy
pythonGH-128533: Add NOT_TAKEN instruction after bytecode optimizat…
c48285e 
…ion. (pythonGH-128554)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@markshannon @picnixz