Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warning popup #5

Open
pypp opened this issue Aug 31, 2022 · 4 comments
Open

warning popup #5

pypp opened this issue Aug 31, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@pypp
Copy link
Owner

pypp commented Aug 31, 2022

image
when film page loads this pops up

@pypp pypp added the bug Something isn't working label Aug 19, 2023
@guytepper
Copy link

Seems to be caused because the extension orverrides the "where to watch" panel, leading to failure of the call to https://letterboxd.com/csi/film/FILM_NAME/availability

@pypp
Copy link
Owner Author

pypp commented Mar 22, 2024

Seems to be caused because the extension orverrides the "where to watch" panel, leading to failure of the call to https://letterboxd.com/csi/film/FILM_NAME/availability

Yeah, this is a konwn issue.
The problem is that this way of overriding the original services seems to be the most reliable one. otherwise I would need wait for the /availability request to finish and only then change the services, which I have no way of knowing when would it happen.

@guytepper
Copy link

Isn't the /availability response the HTML for the 'Where to Watch' section? Then you can use something like MutationObserver to listen for when the element is added, and then replace it

@pypp
Copy link
Owner Author

pypp commented Mar 23, 2024

That might be the right solution, I'm gonna try that approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants