Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot pass max_nodes to Assembly #312

Open
dgruano opened this issue Oct 15, 2024 · 2 comments
Open

Cannot pass max_nodes to Assembly #312

dgruano opened this issue Oct 15, 2024 · 2 comments

Comments

@dgruano
Copy link
Contributor

dgruano commented Oct 15, 2024

Running:
asm = Assembly((pdonr_plasmid, insert), limit=6, max_nodes=10)
gives me:
TypeError: Assembly.__init__() got an unexpected keyword argument 'max_nodes'
Is this intended, or should we be able to pass max_nodes when instanciating a new Assembly object?

@manulera
Copy link
Collaborator

manulera commented Oct 15, 2024

This should probably be removed from the Assembly class docstring, since you actually use it in assemble_linear instead (check the assemble_linear docstring). This is probably some remnant of how it used to be before

@BjornFJohansson
Copy link
Collaborator

Absolutely! max_nodes is passed in the assemble methods. It is a parameter that I rarely used and perhaps something that might not be needed once we have manuels new assembly code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants