Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implicit fallthroughs prevent compiler warning enablement #455

Open
r-barnes opened this issue Jun 26, 2024 · 1 comment
Open

Implicit fallthroughs prevent compiler warning enablement #455

r-barnes opened this issue Jun 26, 2024 · 1 comment
Labels

Comments

@r-barnes
Copy link

Describe the bug
There are a number of places like this where the code does an implicit fallthrough.

Could these please be marked with __attribute__((fallthrough)) (for C code) or [[fallthrough]] (for C++17 and above code)? That enables the use of -Wimplicit-fallthrough which requires that all fallthroughs be explicit, reducing potential error surfaces.

To Reproduce
To assist in reproducing the bug, please include the following:

  1. Command/code being executed: N/A
  2. Python version and OS: N/A
  3. pip version: master
  4. Output of pip list or conda list: N/A

Expected behavior
Fallthroughs are marked explicitly.

Additional context
Add any other context about the problem here.

@rdbisme
Copy link
Collaborator

rdbisme commented Sep 10, 2024

Hello @r-barnes, thanks.

Wanna give it a go with a contribution? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants