-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reused actions maintained by PyPA #47
Comments
As discussed in The-OpenROAD-Project/OpenROAD#1424, wrapping twine in a shell script which is executed in a Container Action is unnecessarily complex. In this context, https://github.com/pyTooling/Actions/blob/main/.github/workflows/PublishOnPyPI.yml#L70-L80 is equivalent to https://github.com/pypa/gh-action-pypi-publish/blob/master/twine-upload.sh#L51-L54, without building and spawning a container. Nevertheless, we can add the "VERIFY_METADATA" and "TWINE_EXTRA_ARGS" options if necessary. Do you have a use case for them? With regard to cibuildwheel, honestly, I don't know what to do. We currently support three different build commands/procedures (https://github.com/pyTooling/Actions/blob/main/.github/workflows/Package.yml):
The first two are expected to be used in repositories containing a Is cibuildwheel a replacement for |
Upon further thinking, all the consumers of pyTooling/Actions are Python-only packages. As far as I understand, in those cases a single wheel can be used regardless of platform (OS or version). That's why we had not considered multiple builds. @proppy do you have a use case that requires building multiple wheels? |
yes The-OpenROAD-Project/OpenROAD#1424 would require to build wheels for a variety of architectures. |
The Python Packaging Authority is now maintaining two actions for building and publish wheels:
Did you consider reusing those?
The text was updated successfully, but these errors were encountered: