Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discuss GitHub Flow #13

Open
akentosh opened this issue Oct 31, 2016 · 0 comments
Open

Discuss GitHub Flow #13

akentosh opened this issue Oct 31, 2016 · 0 comments

Comments

@akentosh
Copy link
Member

jackford [4:29 PM]
Could everyone please always reference your issue in your commits? Also, anyone opposed to rejecting commits without a reference? If people hate the idea no worries (edited)

[4:30]
It make tracking things a lot easier for me. and you can jump right to the issue from the Slack #changelog comment

brett [4:30 PM]
thats fine; i generally do that in the PR itself, per commit seems like you'd just want to push 1 commit per issue (which is the premise of putting it in a PR)

[4:31]
whatever we wanna decide on is fine w/me though; and if we decide i would agree w/rejecting ones w/o meeting that criteria

[4:31]
(cuz i will forget) 🙂

jackford [4:32 PM]
right, and we can have a dummy issue for times when you really don't have/need/want an issue ref.

[4:32]
Mainly it's for things like this: https://github.com/puterstructions/wtfdiw-mobile/tree/setup_travis (edited)

[4:33]
^ that's all that shows in the #changelog and it takes some work to figure out what issue that is so you can go comment on it

[4:33]
BTW, love the use of branches and PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant