Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using wsgi_daemon_process_options logs a deprecation warning but the docs only show the deprecated usage #2537

Open
timmooney opened this issue Mar 27, 2024 · 1 comment · May be fixed by #2553

Comments

@timmooney
Copy link

With any recent version of puppetlabs-apache, in manifests/vhost.pp there is this section of code:

  if $wsgi_daemon_process_options {
    deprecation('apache::vhost::wsgi_daemon_process_options', 'This parameter is deprecated. Please add values inside Hash `wsgi_daemon_process`.')
  }

This triggers a (huge) deprecation warning log message in the puppetserver.log.

The intent seems to be to switch from using the related wsgi_daemon_process option as a string, and instead make it a Hash, likely with the key/value pairs that were being passed in wsgi_daemon_process_options.

The problem is that the documentation doesn't reflect the deprecation. The reference documentation only shows the deprecated usage, not the preferred usage.

Without updated documentation, it's not clear how the String that was the argument to the deprecated use of wsgi_daemon_process is supposed to be incorporated into preferred format Hash.

@mdechiaro
Copy link
Contributor

@timmooney here is an example of how to use wsgi_daemon_process as a Hash.

@ekohl ekohl linked a pull request Jun 17, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants