Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

freeDiskSpaceBeforeTest and freeDiskSpaceBeforeBuild in .ci-mgmt.yaml should be configurable #1095

Closed
thomas11 opened this issue Oct 7, 2024 · 1 comment · Fixed by #1096
Closed

freeDiskSpaceBeforeTest and freeDiskSpaceBeforeBuild in .ci-mgmt.yaml should be configurable #1095

thomas11 opened this issue Oct 7, 2024 · 1 comment · Fixed by #1096
Assignees
@danielrbradley
Labels
kind/engineering Work that is not visible to an external user resolution/fixed This issue was fixed

Comments

@thomas11
Copy link
Contributor

thomas11 commented Oct 7, 2024

Using freeDiskSpaceBeforeBuild: true in pulumi-azure/.ci-mgmt.yaml broke the upgrade-provider workflow for that provider. Its build requires botnet, which removed by freeDiskSpaceBeforeBuild.

The underlying action jlumbroso/free-disk-space supports dotnet: false to preserve dotnet, as well as other components, but these flags are currently hard-coded in ci-mgmt.

Blocks pulumi/pulumi-azure#2518.
@pulumi-bot pulumi-bot added the needs-triage Needs attention from the triage team label Oct 7, 2024
danielrbradley added a commit that referenced this issue Oct 7, 2024
@danielrbradley
Call setup-tools in upgrade-provider
f127f70 
- Ensure we're using our consistent set of tool versions when performing an upgrade.
- Fixes #1095 where we deleted dotnet during disk cleaning.
@danielrbradley danielrbradley mentioned this issue Oct 7, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Oct 7, 2024
@danielrbradley
Fix upgrade-provider tools & disk cleanup (#1096)
b1f731c 
Call setup-tools in upgrade-provider 

- Ensure we're using our consistent set of tool versions when performing
an upgrade.
- Fixes #1095 where we deleted dotnet during disk cleaning.

Never delete the dotnet runtime 
- We actually use this and it should speed up the subsequent tool setup
step.
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Oct 7, 2024
@pulumi-bot
Copy link

Cannot close issue:

  • does not have required labels: kind/

Please fix these problems and try again.

@pulumi-bot pulumi-bot reopened this Oct 7, 2024
@iwahbe iwahbe added kind/engineering Work that is not visible to an external user and removed needs-triage Needs attention from the triage team labels Oct 7, 2024
@iwahbe iwahbe closed this as completed Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielrbradley danielrbradley

Labels
kind/engineering Work that is not visible to an external user resolution/fixed This issue was fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix upgrade-provider tools & disk cleanup pulumi/ci-mgmt
4 participants
@thomas11 @danielrbradley @iwahbe @pulumi-bot