Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please make it work with protobuf editions #541

Open
EugenDueck opened this issue Sep 25, 2024 · 3 comments
Open

Please make it work with protobuf editions #541

EugenDueck opened this issue Sep 25, 2024 · 3 comments

Comments

@EugenDueck
Copy link

I have a file like

edition = "2023";
...

When running protoc-gen-doc like so:

docker run --rm \
  -v $(pwd)/:/out \
  -v $(pwd)/proto:/protos \
  pseudomuto/protoc-gen-doc --doc_opt=markdown,proto-docs.md

It defaults to proto2, leading to many subsequent errors:

[libprotobuf WARNING google/protobuf/compiler/parser.cc:649] No syntax specified for the proto file: echo.proto. Please use 'syntax = "proto2";' or 'syntax = "proto3";' to specify a syntax version. (Defaulted to proto2 syntax.)

@halkeye
Copy link

halkeye commented Oct 9, 2024

I would guess the protobuf dep would need to be updated. https://github.com/pseudomuto/protokit/blob/dc6fd1c8003a61bcd77ddc148e4d49946fbf8c23/go.sum#L3

@abarke
Copy link

abarke commented Dec 9, 2024

yes please support editon = "2023";

@community are there any alternative documentation plugins that support it?

@abarke
Copy link

abarke commented Dec 9, 2024

Failure: plugin "buf.build/community/pseudomuto-doc:v1.5.1" does not support feature "supports editions" which is required by "myproto/v1/myproto.proto"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants