-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More graceful errors when cancelled #53
Comments
This comment has been minimized.
This comment has been minimized.
Is |
This comment has been minimized.
This comment has been minimized.
Jacalz
added a commit
to Jacalz/rymdport
that referenced
this issue
Jun 2, 2021
Needs psanford/wormhole-william#53 fixed to work propertly in all cases.
Jacalz
added a commit
to Jacalz/rymdport
that referenced
this issue
Aug 4, 2021
Needs psanford/wormhole-william#53 fixed to work propertly in all cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As of 049df45, cancelling incomming and outgoing connections works great. However, it would be nice if the errors could be a bit more graceful. This does not affect the latest stable release yet.
Cancelling the outgoing send returns this (first error being in the sending end and the second in the receiving end):
Cancelling the incoming receive returns this. Here, the first error (from the receiving end) is what I would like to see, but the second error is not quite as graceful.
I would like it if all the errors could fail gracefully with "context cancelled".
The text was updated successfully, but these errors were encountered: