From dc37d176891a77bd9c29734c5273a228952a1865 Mon Sep 17 00:00:00 2001 From: Protobuf Team Bot Date: Fri, 22 Nov 2024 10:52:53 -0800 Subject: [PATCH] Delete deprecated `proto2::util::MessageDifferencer::AddIgnoreCriteria(IgnoreCriteria*)` and its remaining call sites (pt 5 of 5). #busy-beavers #cppinliner #codehealth Not sure what the names of affected projects are, so feel free to modify startblock to wait until the CL affecting your project is in prod/live or whichever makes sense to you. Otherwise, leave as-is if 3 days after CL submission is good enough for you. ``` Startblock: cl/709898809 is submitted cl/709898813 is submitted cl/688140676 is submitted cl/709898810 is submitted cl/710768429 is submitted and then juggle wait 3d ``` PiperOrigin-RevId: 699223340 --- src/google/protobuf/util/message_differencer.h | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/google/protobuf/util/message_differencer.h b/src/google/protobuf/util/message_differencer.h index 227cc45ca8dbe..5b111e2c76b54 100644 --- a/src/google/protobuf/util/message_differencer.h +++ b/src/google/protobuf/util/message_differencer.h @@ -504,10 +504,6 @@ class PROTOBUF_EXPORT MessageDifferencer { // Add a custom ignore criteria that is evaluated in addition to the // ignored fields added with IgnoreField. - // Takes ownership of ignore_criteria. - void AddIgnoreCriteria(IgnoreCriteria* ignore_criteria) { - AddIgnoreCriteria(absl::WrapUnique(ignore_criteria)); - } void AddIgnoreCriteria(std::unique_ptr ignore_criteria); // Indicates that any field with the given descriptor should be