From 777d1ce507c1817635a23bd3807afb6eb0fc6eab Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sergio=20Oc=C3=B3n-C=C3=A1rdenas?= Date: Fri, 15 Nov 2024 10:55:33 +0100 Subject: [PATCH] Reverting to the ENV as I can't seem to make the GitHub flow create the ENV --- .github/workflows/docker-image.yml | 3 --- Dockerfile | 5 +---- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/.github/workflows/docker-image.yml b/.github/workflows/docker-image.yml index 146f196..c8defdc 100644 --- a/.github/workflows/docker-image.yml +++ b/.github/workflows/docker-image.yml @@ -41,9 +41,6 @@ jobs: with: images: ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }} - # Workaround for the problem with QEMU. Delete as soon as QEMU 8.1 is part of the build - - name: Set env - run: echo ERL_FLAGS="+JMsingle true" >> $GITHUB_ENV - name: Build and push the Docker image uses: docker/build-push-action@v6 with: diff --git a/Dockerfile b/Dockerfile index 448ff3a..974f656 100644 --- a/Dockerfile +++ b/Dockerfile @@ -42,10 +42,7 @@ RUN mix local.hex --force && \ ENV MIX_ENV="prod" # Add JPperf as workaround for the failure on building the code in Github actions # It should not be necessary with QEMU 8.1, and it introduces some security issues, so delete as as soon as possible -# ENV ERL_FLAGS="+JMsingle true" -ARG ERL_FLAGS="" -ENV ERL_FLAGS=${ERL_FLAGS} -RUN echo "ERL FLAGS FOR THE BUILD: " $ERL_FLAGS +ENV ERL_FLAGS="+JMsingle true" # install mix dependencies