Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis failed (ramsey uuid 4) #133

Open
prolic opened this issue May 2, 2020 · 9 comments
Open

Travis failed (ramsey uuid 4) #133

prolic opened this issue May 2, 2020 · 9 comments
Labels
bug Something isn't working

Comments

@prolic
Copy link
Member

prolic commented May 2, 2020

No description provided.

@prolic prolic added the bug Something isn't working label May 2, 2020
@prolic
Copy link
Member Author

prolic commented May 2, 2020

see ramsey/uuid#314

@prolic
Copy link
Member Author

prolic commented May 2, 2020

I reverted the PR that allowed v4 for now, see prooph/event-store#396

@Nek-
Copy link
Contributor

Nek- commented May 2, 2020

I assume this can be closed then?

@prolic
Copy link
Member Author

prolic commented May 2, 2020

Let's leave it open until we hear back from ramsey.

@prolic prolic closed this as completed Jul 13, 2022
@enumag
Copy link
Member

enumag commented Jul 13, 2022

@prolic why did you close this? I don't think it's fixed

@prolic
Copy link
Member Author

prolic commented Jul 14, 2022

It's two years now and it seems like ramsey's uuid (at least v4) won't get fixed. In case it changes in an upcoming v5 release, we can re-address this.

@enumag
Copy link
Member

enumag commented Jul 14, 2022

Then I think we should try to remove dependency on ramsey/uuid completely. It's widely used so the incompatibility with v4 is a blocker for many users.

@enumag
Copy link
Member

enumag commented Jul 14, 2022

@prolic Alternatively, would it be possible to use the non-GUID format of UUIDs in the library (hence allowing uuid v4) and resolve the byte order manually when loading / saving the data in eventstore?

@prolic
Copy link
Member Author

prolic commented Jul 15, 2022

I'm not sure, have to look into that.

@prolic prolic reopened this Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants