-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Travis failed (ramsey uuid 4) #133
Comments
see ramsey/uuid#314 |
I reverted the PR that allowed v4 for now, see prooph/event-store#396 |
I assume this can be closed then? |
Let's leave it open until we hear back from ramsey. |
@prolic why did you close this? I don't think it's fixed |
It's two years now and it seems like ramsey's uuid (at least v4) won't get fixed. In case it changes in an upcoming v5 release, we can re-address this. |
Then I think we should try to remove dependency on ramsey/uuid completely. It's widely used so the incompatibility with v4 is a blocker for many users. |
@prolic Alternatively, would it be possible to use the non-GUID format of UUIDs in the library (hence allowing uuid v4) and resolve the byte order manually when loading / saving the data in eventstore? |
I'm not sure, have to look into that. |
No description provided.
The text was updated successfully, but these errors were encountered: