Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dotfiles are being ignored #444

Open
KaoruDev opened this issue May 20, 2023 · 1 comment
Open

Dotfiles are being ignored #444

KaoruDev opened this issue May 20, 2023 · 1 comment
Labels
bug help wanted Get involved! We'd love to have your help.

Comments

@KaoruDev
Copy link

TLDR: dotfiles are ignored in exclude option, I believe the bug is here:

.flat_map { |path| Dir[path.to_s] }

and changing it to Dir.glob(path.tos, File::FNM_DOTMATCH)

According to: https://stackoverflow.com/questions/11385795/how-to-list-directory-contents-including-dotfiles-but-not-and

Steps to reproduce

I have the following structure:

.buildkite/src/
  package.json
  index.js
  .eslintrc.js
.eslintrc.json
packaage.json

And the following config:

all:
  exclude:
    - ".buildkite/**/*"

However, dotfile changes are still getting picked up by pronto.

@ashkulz
Copy link
Member

ashkulz commented Jan 13, 2025

@KaoruDev happy to accept a PR which implements this.

@ashkulz ashkulz added bug help wanted Get involved! We'd love to have your help. labels Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug help wanted Get involved! We'd love to have your help.
Projects
None yet
Development

No branches or pull requests

2 participants