Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pronto and syntax errors #86

Open
renatolond opened this issue Feb 28, 2023 · 0 comments
Open

Pronto and syntax errors #86

renatolond opened this issue Feb 28, 2023 · 0 comments

Comments

@renatolond
Copy link
Contributor

Using ruby 2.7.x, if I create a syntax error, rubocop reports it at the end of the file:

Inspecting 1 file
E

Offenses:

config.ru:179:1: E: Lint/Syntax: unexpected token $end
(Using Ruby 2.7 parser; configure using TargetRubyVersion parameter, under AllCops)

1 file inspected, 1 offense detected

However, the error was introduced in a previous line.
This means that if we're running rubocop directly, we would see that this file is not parseable, but using pronto there's no complaints (this flies under the radar in a CI check, for instance).

Would it make sense that pronto always reports Syntax errors on touched files, even outside of the patch zone?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant