Unable to comment on PR #18
Comments
|
@mmozuras I'm trying to hunt this one. I can see that the SHA is not getting into the url.
The part |
|
The comment by @jdq22 at prontolabs/pronto#353 (comment) made me pay closer attention to Running a clean There's no line number indications and the file name is wrong. Perhaps the problematic part of the code is: def inspect(patch)
offences = Eslintrb.lint(patch.new_file_full_path, options).compact
fatals = offences.select { |offence| offence['fatal'] }
.map { |offence| new_message(offence, nil) }
return fatals if fatals && !fatals.empty?
offences.map do |offence|
patch.added_lines.select { |line| line.new_lineno == offence['line'] }
.map { |line| new_message(offence, line) }
end
endFrom: https://github.com/prontolabs/pronto-eslint/blob/master/lib/pronto/eslint.rb#L15 Mainly the way how it treats fatal errors (prematurely returning). Perhaps I can come up with patch soon. |
Examples of fatal and non-fatal returns by EslintrbFatal rule by eslintrb {"ruleId"=>nil,
"fatal"=>true,
"severity"=>2,
"source"=>"import { Doughnut } from 'vue-chartjs';",
"message"=>"Parsing error: The keyword 'import' is reserved",
"line"=>2,
"column"=>1}Non-fatal rule {"ruleId"=>"strict",
"severity"=>2,
"source"=>"$(function () {",
"message"=>"Use the function form of 'use strict'.",
"line"=>6,
"column"=>3,
"nodeType"=>"FunctionExpression"
} |
|
A fatal rule by fail to pass { "ruleId"=>nil,
"fatal"=>true,
"severity"=>2,
"source"=>nil,
"message"=>"Parsing error: ecmaVersion must be 3, 5, 6, or 7."} |
|
@abinoam if you're open to submitting a fix those this it would be greatly appreciated 😁 |
|
Did you find a solution for this? Moving to Git Hub actions we are now seeing this exact problem |
|
It's been a while since then. I've had a storm of things to do at that time and it just stayed untouched. Sorry. |
|
We ran into the same issue just now and to me the issue seems to come from using pronto-eslint/lib/pronto/eslint.rb Line 41 in 46848c9 I am proposing the following change: #24 |
Environment:
It seems there is a problem posting comment on a PR as follow:
Comment message:
Back trace:
The text was updated successfully, but these errors were encountered: